Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only Quick Sort Page #102

Merged
merged 4 commits into from
Jul 13, 2024
Merged

Conversation

AkshatPandey-2004
Copy link
Contributor

Label: Bonus

Email id: [email protected]

Copy link

vercel bot commented Jul 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
visual-sort ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 12, 2024 8:31pm

@MastanSayyad
Copy link
Owner

@AkshatPandey-2004 Where did you add the page link as the quick sort link in algorithms dropdown is empty

@MastanSayyad MastanSayyad requested review from MastanSayyad and RadhikaMalpani1702 and removed request for MastanSayyad July 12, 2024 18:58
Copy link
Owner

@MastanSayyad MastanSayyad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AkshatPandey-2004 I cant redirect to the pages please add the respective navlinks

@AkshatPandey-2004
Copy link
Contributor Author

Okay Doing it now @MastanSayyad

@AkshatPandey-2004 AkshatPandey-2004 changed the title Quick Sort Page Quick Sort Page and Merge Sort Jul 12, 2024
@AkshatPandey-2004
Copy link
Contributor Author

@MastanSayyad Done
now you can check it

@MastanSayyad
Copy link
Owner

@AkshatPandey-2004 I think you added only in index.html navbar as when i go to quick sort page and try redirect from there to other sorting pages then it shows error

please ensure you update the links in each pages navbar so that users can easily access to them

@AkshatPandey-2004
Copy link
Contributor Author

@MastanSayyad Okay and i m adding all the pages in this pr only okay ..

@MastanSayyad
Copy link
Owner

It is not possible as per the guidelines, one PR can only get max points 50 only!

@MastanSayyad
Copy link
Owner

I have to assign the score as per the number of PR merged with their assign scores, i have to update the score report to the moderators, that's why I need PR numbers for repsective scores @AkshatPandey-2004

I already told you to create individual PRs for each page and i will only assign 40 points each and at last Two Algorithms PRs i will assign 50 points!! ( as you know at start you were only asking for Hard label 20 points but I have increase it to Bonus 40 points and for last two PRs 50-50 bonus points)

@MastanSayyad
Copy link
Owner

If you can add Footers and Scroll to top button ( which already exists in index.html) then i can assign 50 points to each PR ( as a developer we must ensure consistency across all the pages to look more real and everything at one place) @AkshatPandey-2004

@AkshatPandey-2004
Copy link
Contributor Author

@MastanSayyad Okay Then i m adding footer and scroll top button in each page..making seprate pr for each :)

@AkshatPandey-2004 AkshatPandey-2004 changed the title Quick Sort Page and Merge Sort Only Quick Sort Page Jul 12, 2024
@MastanSayyad MastanSayyad merged commit ccc5f3f into MastanSayyad:main Jul 13, 2024
1 check passed
@MastanSayyad MastanSayyad added BONUS issue is very hard VSoC’24 Contribution under VSoC'24 labels Jul 13, 2024
@AkshatPandey-2004
Copy link
Contributor Author

issue #122

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BONUS issue is very hard VSoC’24 Contribution under VSoC'24
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants